Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Oct 28, 2024

Problem solved

CleanShot 2024-10-29 at 09.56.32@2x.png


PR-Codex overview

This PR focuses on enhancing the handling of transactions in the thirdweb application, specifically regarding unsupported Pay chains and improving user interface elements for better transaction management.

Detailed summary

  • Added handling for unsupported Pay chains in sending paid transactions.
  • Updated fetchBuySupportedDestinations to be an exported async function.
  • Changed the PayTransactionButtonPreview to display a "Buy VIP Pass" button.
  • Improved transaction error handling and support checks.
  • Updated tests to reflect new transaction handling logic.
  • Enhanced UI elements in TransactionModeScreen for better user feedback and interaction.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 9:27pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 9:27pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 9:27pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 9:27pm

@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2024

🦋 Changeset detected

Latest commit: acf1544

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 28, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added Playground Changes involving the Playground codebase. packages labels Oct 28, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@joaquim-verges joaquim-verges force-pushed the feat_enhance_TransactionButton_and_add_buy_support_check branch from 3ce50c9 to acf1544 Compare October 28, 2024 20:51
@joaquim-verges joaquim-verges marked this pull request as ready for review October 28, 2024 20:52
@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.9 KB (0%) 859 ms (0%) 716 ms (+33.74% 🔺) 1.6 s
thirdweb (cjs) 102.73 KB (0%) 2.1 s (0%) 1.2 s (+15.02% 🔺) 3.3 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 197 ms (+243.58% 🔺) 294 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 11 ms (+2.78% 🔺) 21 ms
thirdweb/react (minimal + tree-shaking) 17.34 KB (0%) 347 ms (0%) 143 ms (+76.96% 🔺) 490 ms

@codecov
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.32%. Comparing base (aa0f397) to head (acf1544).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5207      +/-   ##
==========================================
+ Coverage   45.30%   45.32%   +0.02%     
==========================================
  Files        1067     1067              
  Lines       55304    55272      -32     
  Branches     3970     3970              
==========================================
  Hits        25054    25054              
+ Misses      29557    29525      -32     
  Partials      693      693              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from aa0f397
packages 40.33% <ø> (+0.02%) ⬆️ Carriedforward from aa0f397

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...react/core/hooks/transaction/useSendTransaction.ts 7.47% <ø> (+0.26%) ⬆️
...onnectWallet/screens/Buy/TransactionModeScreen.tsx 1.11% <ø> (+0.14%) ⬆️
...tWallet/screens/Buy/swap/useSwapSupportedChains.ts 4.83% <ø> (+0.07%) ⬆️

@joaquim-verges joaquim-verges merged commit adeda1e into main Oct 28, 2024
31 checks passed
@joaquim-verges joaquim-verges deleted the feat_enhance_TransactionButton_and_add_buy_support_check branch October 28, 2024 21:41
@jnsdls jnsdls mentioned this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages Playground Changes involving the Playground codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants